Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash if some configs values aren't present #1388

Merged

Conversation

aronwk-aaron
Copy link
Member

remove not starting if ini's aren't present since everything can run from env vars now

tested running a server with no ini's and the db connector game proper feedback
tested running with only the MYSQL_XXXX configs set as env vars and the server ran perfect and I was able to connect with a client

Xiphoseer
Xiphoseer previously approved these changes Jan 4, 2024
dAuthServer/AuthServer.cpp Outdated Show resolved Hide resolved
@EmosewaMC EmosewaMC changed the title fix: don't crash if some configs aren't present fix: don't server checking if configs aren't present Jan 4, 2024
@EmosewaMC EmosewaMC changed the title fix: don't server checking if configs aren't present fix: d server checking if configs aren't present Jan 4, 2024
@EmosewaMC EmosewaMC changed the title fix: d server checking if configs aren't present fix: remove server checking if configs aren't present Jan 4, 2024
@EmosewaMC EmosewaMC changed the title fix: remove server checking if configs aren't present fix: don't crash if some configs values aren't present Jan 4, 2024
remove not starting if ini's aren't present since everything can run from env vars now
@aronwk-aaron aronwk-aaron force-pushed the fix--make-all-settings-have-sane-defaults-where-possible branch from af7ceb0 to 321d354 Compare January 5, 2024 00:21
@aronwk-aaron
Copy link
Member Author

retested things, they work.
Was probably doing something stupid and didn't see it

@aronwk-aaron aronwk-aaron requested a review from Xiphoseer January 5, 2024 00:44
dPhysics/dpWorld.cpp Show resolved Hide resolved
dPhysics/dpWorld.h Show resolved Hide resolved
@DarwinAnim8or DarwinAnim8or merged commit 66ac5a1 into main Jan 5, 2024
4 checks passed
@Xiphoseer Xiphoseer deleted the fix--make-all-settings-have-sane-defaults-where-possible branch January 5, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants